Code clean up

This commit is contained in:
Lukasz Baldyga committed 2020-11-29 11:00:52 +00:00
1 parent 9ee1c79795
commit c726739419
6 files changed
+41 -47

No files matched your search

@@ -29,107 +29,107 @@
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.MoveToTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.MoveToTester_Manual1">
<summary> <summary>
tests the "move" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.MoveTo"/>. tests the "move" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.MoveTo" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.MoveToTester_Manual2"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.MoveToTester_Manual2">
<summary> <summary>
tests the "moveto" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.MoveTo"/>. tests the "moveto" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.MoveTo" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.DrawToTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.DrawToTester_Manual1">
<summary> <summary>
tests the "drawto" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.DrawTo"/>. tests the "drawto" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.DrawTo" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.DrawToTester_Manual2"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.DrawToTester_Manual2">
<summary> <summary>
tests the "line" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.DrawTo"/>. tests the "line" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.DrawTo" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.DrawToTester_Manual3"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.DrawToTester_Manual3">
<summary> <summary>
tests the "lineto" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.DrawTo"/>. tests the "lineto" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.DrawTo" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.RegularPolygonTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.RegularPolygonTester_Manual1">
<summary> <summary>
tests the "regularpolygon" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.RegularPolygon"/>. tests the "regularpolygon" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.RegularPolygon" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.RegularPolygonTester_Manual2"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.RegularPolygonTester_Manual2">
<summary> <summary>
tests the "rp" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.RegularPolygon"/>. tests the "rp" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.RegularPolygon" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.RegularPolygonTester_Manual3"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.RegularPolygonTester_Manual3">
<summary> <summary>
tests the "regularpolygon" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.RegularPolygon"/>. tests the "regularpolygon" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.RegularPolygon" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.RegularPolygonTester_Manual4"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.RegularPolygonTester_Manual4">
<summary> <summary>
tests the "rp" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.RegularPolygon"/>. tests the "rp" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.RegularPolygon" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.SquareTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.SquareTester_Manual1">
<summary> <summary>
tests the "square" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Square"/>. tests the "square" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Square" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.SquareTester_Manual2"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.SquareTester_Manual2">
<summary> <summary>
tests the "square" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Square"/>. tests the "square" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Square" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.QuadrilateralTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.QuadrilateralTester_Manual1">
<summary> <summary>
tests the "quadrilateral" command using <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.DrawLines"/>. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Quadrilateral"/>. tests the "quadrilateral" command using <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.DrawLines" />. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Quadrilateral" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.CircleTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.CircleTester_Manual1">
<summary> <summary>
Tests the "circle" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Circle"/>. Tests the "circle" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Circle" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.TriangleTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.TriangleTester_Manual1">
<summary> <summary>
tests the "triangle" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Triangle"/>. tests the "triangle" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Triangle" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.TriangleTester_Manual2"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.TriangleTester_Manual2">
<summary> <summary>
tests the "triangle" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Triangle"/>. tests the "triangle" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Triangle" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.DotTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.DotTester_Manual1">
<summary> <summary>
test the "dot" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Dot"/>. test the "dot" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Dot" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.ClearTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.ClearTester_Manual1">
<summary> <summary>
tests the "clear" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Circle"/>. tests the "clear" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.Circle" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.ResetPenTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.ResetPenTester_Manual1">
<summary> <summary>
Tests the "reset" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.ResetPen"/> Tests the "reset" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.ResetPen" />
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.ResetPenTester_Manual2"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.ResetPenTester_Manual2">
<summary> <summary>
Tests the "resetpen" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.ResetPen"/>. Tests the "resetpen" command. See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.ResetPen" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.PenTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.PenTester_Manual1">
<summary> <summary>
Tests the command "pen". See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.PenColor"/> Tests the command "pen". See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.PenColor" />
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.FillTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.FillTester_Manual1">
<summary> <summary>
Tests the command "fill". See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.FillColor"/>. Tests the command "fill". See <see cref="T:Advanced_Software_Engineering.Verbs.DrawingVerbs.FillColor" />.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.CommandTester.IfTester_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.CommandTester.IfTester_Manual1">
@@ -165,7 +165,7 @@
</member> </member>
<member name="T:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester"> <member name="T:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester">
<summary> <summary>
This class tests <see cref="T:Advanced_Software_Engineering.SettingsAndHelperFunctions"/> methods. It uses a combination of manual and random tests. This class tests <see cref="T:Advanced_Software_Engineering.SettingsAndHelperFunctions" /> methods. It uses a combination of manual and random tests.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.Strip_Random1"> <member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.Strip_Random1">
@@ -175,72 +175,72 @@
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.Strip_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.Strip_Manual1">
<summary> <summary>
Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.Strip(System.String)"/> test Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.Strip(System.String)" /> test
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.Strip_Manual2"> <member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.Strip_Manual2">
<summary> <summary>
Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.Strip(System.String)"/> test Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.Strip(System.String)" /> test
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.StripStringArray_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.StripStringArray_Manual1">
<summary> <summary>
Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.StripStringArray(System.String[])"/> test. Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.StripStringArray(System.String[])" /> test.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.StripStringArray_Manual2"> <member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.StripStringArray_Manual2">
<summary> <summary>
Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.StripStringArray(System.String[])"/> test. Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.StripStringArray(System.String[])" /> test.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.CommandAndParameterParser_Manual1"> <member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.CommandAndParameterParser_Manual1">
<summary> <summary>
Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.CommandAndParameterParser(System.String)"/> test. Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.CommandAndParameterParser(System.String)" /> test.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.CommandAndParameterParser_Manual2"> <member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.CommandAndParameterParser_Manual2">
<summary> <summary>
Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.CommandAndParameterParser(System.String)"/> test. Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.CommandAndParameterParser(System.String)" /> test.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.CommandAndParameterParser_Manual3"> <member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.CommandAndParameterParser_Manual3">
<summary> <summary>
Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.CommandAndParameterParser(System.String)"/> test. Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.CommandAndParameterParser(System.String)" /> test.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.CommandAndParameterParser_Manual4"> <member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.CommandAndParameterParser_Manual4">
<summary> <summary>
Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.CommandAndParameterParser(System.String)"/> test. Manual <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.CommandAndParameterParser(System.String)" /> test.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.CommandAndParameterParser_Random1"> <member name="M:Advanced_Software_Engineering_Tests.SettingsAndHelperFunctionsTester.CommandAndParameterParser_Random1">
<summary> <summary>
Random <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.CommandAndParameterParser(System.String)"/> test. Random <see cref="M:Advanced_Software_Engineering.SettingsAndHelperFunctions.CommandAndParameterParser(System.String)" /> test.
</summary> </summary>
</member> </member>
<member name="T:Advanced_Software_Engineering_Tests.ValueHelperTester"> <member name="T:Advanced_Software_Engineering_Tests.ValueHelperTester">
<summary> <summary>
This class tests <see cref="T:Advanced_Software_Engineering.Verbs.Value.ValueHelper"/> methods. It uses a combination of manual and random tests. This class tests <see cref="T:Advanced_Software_Engineering.Verbs.Value.ValueHelper" /> methods. It uses a combination of manual and random tests.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.ValueHelperTester.ConvertToInt_Random1"> <member name="M:Advanced_Software_Engineering_Tests.ValueHelperTester.ConvertToInt_Random1">
<summary> <summary>
Random <see cref="M:Advanced_Software_Engineering.Verbs.Value.ValueHelper.ConvertToInt(System.String)"/> test. Random <see cref="M:Advanced_Software_Engineering.Verbs.Value.ValueHelper.ConvertToInt(System.String)" /> test.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.ValueHelperTester.ConvertToDouble_Random1"> <member name="M:Advanced_Software_Engineering_Tests.ValueHelperTester.ConvertToDouble_Random1">
<summary> <summary>
Random <see cref="M:Advanced_Software_Engineering.Verbs.Value.ValueHelper.ConvertToDouble(System.String)"/> test. Random <see cref="M:Advanced_Software_Engineering.Verbs.Value.ValueHelper.ConvertToDouble(System.String)" /> test.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.ValueHelperTester.ConvertToDouble_Random2"> <member name="M:Advanced_Software_Engineering_Tests.ValueHelperTester.ConvertToDouble_Random2">
<summary> <summary>
Random <see cref="M:Advanced_Software_Engineering.Verbs.Value.ValueHelper.ConvertToDouble(System.String)"/> test. Random <see cref="M:Advanced_Software_Engineering.Verbs.Value.ValueHelper.ConvertToDouble(System.String)" /> test.
</summary> </summary>
</member> </member>
<member name="M:Advanced_Software_Engineering_Tests.ValueHelperTester.ConvertToDouble_Random3"> <member name="M:Advanced_Software_Engineering_Tests.ValueHelperTester.ConvertToDouble_Random3">
<summary> <summary>
Random <see cref="M:Advanced_Software_Engineering.Verbs.Value.ValueHelper.ConvertToDouble(System.String)"/> test. Random <see cref="M:Advanced_Software_Engineering.Verbs.Value.ValueHelper.ConvertToDouble(System.String)" /> test.
</summary> </summary>
</member> </member>
</members> </members>
@@ -1,5 +1,4 @@
using System.Collections.Generic; using System.Collections.Generic;
using System.Windows.Forms;
namespace Advanced_Software_Engineering { namespace Advanced_Software_Engineering {
@@ -1,11 +1,9 @@
using System; using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
namespace Advanced_Software_Engineering { namespace Advanced_Software_Engineering {
public static partial class MenuManager { public static partial class MenuManager {
/// <summary> /// <summary>
/// The variable simply keep track of the windows that are currently shown (excluding <see cref="Menu"/>). /// The variable simply keep track of the windows that are currently shown (excluding <see cref="Menu"/>).
/// </summary> /// </summary>
@@ -1,5 +1,4 @@
using System; using System;
using System.Collections.Generic;
namespace Advanced_Software_Engineering.Verbs.Value { namespace Advanced_Software_Engineering.Verbs.Value {
@@ -10,6 +9,7 @@ namespace Advanced_Software_Engineering.Verbs.Value {
//Common characters that people might try //Common characters that people might try
private char[] illegalCharacters = "1234567890!?/+- \"'@#~;:><,.`¬|[]{}\\£$%^&*()".ToCharArray(); private char[] illegalCharacters = "1234567890!?/+- \"'@#~;:><,.`¬|[]{}\\£$%^&*()".ToCharArray();
private string[] illegalNames = private string[] illegalNames =
{ "var", { "var",
"move", "moveto", "move", "moveto",
@@ -49,7 +49,7 @@ namespace Advanced_Software_Engineering.Verbs.Value {
this.drawer = drawer; this.drawer = drawer;
//seperate assignment characters from everything else //seperate assignment characters from everything else
foreach(string op in new string[]{ "=", "+", "-", "*", "/" }) { foreach (string op in new string[] { "=", "+", "-", "*", "/" }) {
assignment = assignment.Replace(op, " " + op + " "); assignment = assignment.Replace(op, " " + op + " ");
} }
@@ -97,7 +97,6 @@ namespace Advanced_Software_Engineering.Verbs.Value {
throw new Exception("Not implemented yet"); throw new Exception("Not implemented yet");
} }
} }
} }
public void ExecuteVerb() { public void ExecuteVerb() {
@@ -26,7 +26,7 @@ namespace Advanced_Software_Engineering.Verbs.Value {
} }
public ExpressionValue(Drawer drawer, IValue variable1, IValue variable2, string operation) { public ExpressionValue(Drawer drawer, IValue variable1, IValue variable2, string operation) {
switch(operation) { switch (operation) {
case "+": case "+":
this.operation = ADD; this.operation = ADD;
break; break;
@@ -50,7 +50,6 @@ namespace Advanced_Software_Engineering.Verbs.Value {
this.variable1 = variable1; this.variable1 = variable1;
this.variable2 = variable2; this.variable2 = variable2;
//Check for bad input //Check for bad input
if (this.operation > 3 && this.operation < 0) throw new Exception("Bad operation"); if (this.operation > 3 && this.operation < 0) throw new Exception("Bad operation");
} }
@@ -30,7 +30,6 @@ namespace Advanced_Software_Engineering {
//check for names in directory //check for names in directory
if (drawer.CheckVariableExists(command)) { if (drawer.CheckVariableExists(command)) {
if (commandParameters.Length == 1) { if (commandParameters.Length == 1) {
return new UpdateVariable(drawer, command, ValueFactory.CreateValue(drawer, commandParameters[0])); return new UpdateVariable(drawer, command, ValueFactory.CreateValue(drawer, commandParameters[0]));
} else throw new Exception(command + "needs something to be assigned to it"); } else throw new Exception(command + "needs something to be assigned to it");